1. Hello Guest!
    Welcome to the Bug Report forum, please make sure you search for your problem before posting here. If you post a duplicate (that you post the same issue while other people have already done that before) you will be given a warning point which can eventually lead into account limitations !

    Here you can find a guide on how to post a good bug report thread.
    Space Engineers version --- Medieval Engineers version
  2. This forum is obsolete and read-only. Feel free to contact us at support.keenswh.com

Code analyzer found thousands of bugs in SE

Discussion in 'Bug Reports' started by zorgkirill, Apr 15, 2017.

Thread Status:
Not open for further replies.
This last post in this thread was made more than 31 days old.
  1. zorgkirill

    zorgkirill Apprentice Engineer

    More than a year ago, there was an article about SE check with static code analyzer ( https://www.viva64.com/en/b/0376/ ). It's results were:
    75 important,
    92 medium,
    817 unimportant warnings/errors.

    After around a month, I made the same check with newer SE source code (Feb 2016 end), here's the result:
    92 important warnings,
    152 medium,
    874 small warnings/errors.

    We can see error growth.

    And now...(drumroll)... game check from 06.01.2017 (last source-code update on Github):
    350 (LOOL) important,
    748 medium,
    1063 small warnings/errors...

    It seems that bugfixing is going wrong...

    Here's proof of last check: [​IMG]
    • Agree Agree x 3
    • Like Like x 2
  2. Roxette

    Roxette Senior Engineer

    Clearly this is an invalid system to check the SE code with, as it is called "static code analyzer" and the SE code is dynamic, as it changes at least once a week :D
    • Funny Funny x 2
  3. The_Netos

    The_Netos Trainee Engineer

    When the QA department drank too much beer :D
  4. gornyakmaniac

    gornyakmaniac Apprentice Engineer

    These are not bugs, these are scheduled features
    • Funny Funny x 5
  5. Gwindalmir

    Gwindalmir Senior Engineer

    Static analysis doesn't always show bugs, but more like improper coding techniques, or failures to clean up due to changing code.
    Yes it can reveal bugs, but not always. Some of them, like the 'comparison is never true' could simply be dead code which really should just be removed.
    I'm sure that'll eventually get cleaned up, but static analysis has to be manually run, it's not something the compiler just does. Which means they don't show up during builds, and are less visible.

    For example, naming a constant in ALL_CAPS, as is standard in C, is flagged in C#, and Keen does that. That's not a bug, just a break in C# coding standards.
  6. Jimmacle

    Jimmacle Trainee Engineer

    So you're running a tool against GitHub code that's 3 months out of date and is so gimped it doesn't compile for legal reasons, and you're trying to say that compiler warnings in that mean the game is getting buggier? Lul.
  7. rexxar

    rexxar Senior Engineer

    To summarize this thread, there are bugs in the game, and there has been a ton of code added in the last few months.

    In other news, grass is green, water is wet, and this thread is closed.
    • Like Like x 3
    • Funny Funny x 2
Thread Status:
Not open for further replies.
This last post in this thread was made more than 31 days old.